drop usage of userID for names of UserSignup #501
Conversation
MatousJobanek
requested review from
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
mfrancisc,
rsoaresd,
fbm3307 and
metlos
as code owners
|
|
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #501 +/- ##
==========================================
- Coverage 85.12% 85.11% -0.01%
==========================================
Files 32 32
Lines 3146 3118 -28
==========================================
- Hits 2678 2654 -24
+ Misses 380 376 -4
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MatousJobanek
merged commit 280e4ec
into
codeready-toolchain:master
The final PR of the whole effort of dropping support for using userIds as the names of UserSignups KUBESAW-254
To simplify the code, the PR also removes the
GetUserSignupFromIdentifiermethod as not needed anymore. Every caller that needs to get UserSignup resource can simply callGetwith the encoded username.paired PR: codeready-toolchain/toolchain-e2e#1105